Fix phpdbg local console mode when using libedit/readline#13199
Closed
petk wants to merge 1 commit into
Closed
Conversation
When using libedit/readline integration in phpdbg, EOF makes editline write prompt again in local console mode. For example, this can be noticed when reading phpt test files from STDIN and running phpdbg.
petk
added a commit
to petk/php-build-system
that referenced
this pull request
Mar 19, 2024
This fixes warnings that fill up the build log due to different compilation flags used and clang. See: php/php-src#13199
remicollet
approved these changes
Aug 1, 2024
remicollet
left a comment
remicollet
left a comment
Member
There was a problem hiding this comment.
I confirm phpdbg test suite passes with this fix
Member
|
Perhaps worth applying in maintained branches (at least 8.3 is affected) |
Member
|
Tested on 8.2, 8.3 and master |
petk
added a commit
that referenced
this pull request
Aug 2, 2024
* PHP-8.2: Fix GH-13199: Redundant prompt in phpdbg with libedit/readline
petk
added a commit
that referenced
this pull request
Aug 2, 2024
* PHP-8.3: Fix GH-13199: Redundant prompt in phpdbg with libedit/readline
Member
Author
|
Ok, thanks for the review. Added to PHP-8.2 and up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using libedit/readline integration in phpdbg, EOF makes editline write prompt again in local console mode. For example, this can be noticed when reading phpt test files from STDIN and running phpdbg.
How to reproduce the issue:
./configure --with-readline --enable-phpdbg-readline make ./sapi/cli/php run-tests.php sapi/phpdbg # here tests fail with prompt being repeated in the outputAfter this patch, phpdbg tests pass.